git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] git-bisect: use update-ref to mark good/bad commits

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 15, 2007, 09:01 UTC
Message-ID
<7vk5oj6fx2.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20071115081807.06fe092b.chriscool@tuxfamily.org>

This removes the last instance of making a ref by hand with "echo SHA1 >.git/refs/$refname" from the script and replaces it with update-ref.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 git-bisect.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index 3a21033..4b74a7b 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -130,7 +130,7 @@ bisect_write() {
 		good|skip)	tag="$state"-"$rev" ;;
 		*)		die "Bad bisect_write argument: $state" ;;
 	esac
-	echo "$rev" >"$GIT_DIR/refs/bisect/$tag"
+	git update-ref "refs/bisect/$tag" "$rev"
 	echo "# $state: "$(git show-branch $rev) >>"$GIT_DIR/BISECT_LOG"
 	test -z "$nolog" && echo "git-bisect $state $rev" >>"$GIT_DIR/BISECT_LOG"
 }
-- 
1.5.3.5.1780.gca2b
Previous: David KastrupNext: Junio C Hamano
Message 14 of 18 in “Bisect reset: remove bisect refs that may have been packed.”
  1. Bisect reset: remove bisect refs that may have been packed.Christian Couder, Nov 15, 2007
  2. Junio C HamanoNov 15, 2007
  3. Johannes SixtNov 15, 2007
  4. Shawn O. PearceNov 15, 2007
  5. Jeff KingNov 15, 2007
  6. Johannes SchindelinNov 15, 2007
  7. Junio C HamanoNov 15, 2007
  8. 1/3 git-bisect: war on "sed"Junio C Hamano, Nov 15, 2007
  9. Miles BaderNov 15, 2007
  10. Wincent ColaiutaNov 15, 2007
  11. Miles BaderNov 15, 2007
  12. Andreas EricssonNov 15, 2007
  13. David KastrupNov 15, 2007
  14. 2/3 git-bisect: use update-ref to mark good/bad commitsJunio C Hamano, Nov 15, 2007
  15. 3/3 git-bisect: modernize branch shuffling hackJunio C Hamano, Nov 15, 2007
  16. Miles BaderNov 15, 2007
  17. David KastrupNov 15, 2007
  18. Miles BaderNov 15, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.