git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Set up argv0_path correctly, even when argv[0] is just the basename

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 26, 2008, 17:31 UTC
Message-ID
<7vod4kft7d.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0807261613120.26810@eeepc-johanness>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> When the program 'git' is in the PATH, the argv[0] is set to the basename.

While it may be true, I do not think it matters that we cannot get the full path _UNLESS_ we are doing the relative "../" business. 

> However, argv0_path needs the full path, so add a function to discover the
> program by traversing the PATH manually.

I think unconditionally requiring argv0_path to be set is the root cause of the bug. Unless we do not fix _that_, we will have to make a needless call to lookup_program_in_path() even when nobody needs that information, which is unacceptable.

Previous: Rene HermanNext: Johannes Schindelin
Message 10 of 21 in “Modify mingw_main() workaround to avoid link errors”
  1. Modify mingw_main() workaround to avoid link errorsSteffen Prohaska, Jul 26, 2008
  2. Johannes SchindelinJul 26, 2008
  3. Steffen ProhaskaJul 26, 2008
  4. Set up argv0_path correctly, even when argv[0] is just the basenameJohannes Schindelin, Jul 26, 2008
  5. Rene HermanJul 26, 2008
  6. Johannes SchindelinJul 26, 2008
  7. Rene HermanJul 26, 2008
  8. Johannes SchindelinJul 26, 2008
  9. Rene HermanJul 26, 2008
  10. Junio C HamanoJul 26, 2008
  11. Johannes SchindelinJul 26, 2008
  12. Jan HudecAug 3, 2008
  13. Junio C HamanoAug 3, 2008
  14. Johannes SixtJul 26, 2008
  15. Steffen ProhaskaJul 26, 2008
  16. Johannes SixtJul 27, 2008
  17. Steffen ProhaskaJul 29, 2008
  18. Johannes SixtJul 29, 2008
  19. Steffen ProhaskaJul 29, 2008
  20. Johannes SixtAug 3, 2008
  21. Junio C HamanoAug 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.