Re: [PATCH 2/2] http-push: remove MOVE step after PUT when sending objects to server
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 18, 2009, 20:05 UTC
- Message-ID
- <7vocy4wfb2.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.DEB.1.00.0901181425420.3586@pacific.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 10 quoted lines
> The point is: the repository inside the document root of the web server is > still a valid repository. > > And the assumption is that whenever you have a file that looks like a > valid object/pack inside a valid repository, that it does not need > replacing. > > So even when optimizing the uncommon (HTTP push is 2nd class citizen), we > have to keep the common workflow intact (1st class citizens _are_ push by > file system, ssh or git://).
The first class citizens are "local use", not "copying out of the area that looks like a repository only to http:// transport users".
> Which unfortunately means that put && move must stay.
I still do not understand why it is unfortunate.
As far as I understand, Ray's issue was that his filesystem did not like the temporary file name that is used for the initial "put" phase because it contained a character it did not like (colon, perhaps). Why isn't the patch about changing _that_ single issue?