Re: [PATCH 2/2] http-push: remove MOVE step after PUT when sending objects to server
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 18, 2009, 00:48 UTC
- Message-ID
- <7viqod5thi.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <be6fef0d0901171224y35c3d95cn2d38639ac03c3b8f@mail.gmail.com>
"Ray Chuan" <rctay89@gmail.com> writes:
Show 15 quoted lines
> Currently, git PUTs to > > /repo.git/objects/1a/1a2b...9z_opaquelocktoken:1234-.... > > then MOVEs to > > /repo.git/objects/1a/1a2b...9z > > This is needless. In fact, the only time MOVE requests are sent is for > this sole purpose (ie. of renaming an object). > > A concern raised was repository corruption in the event of failure > during PUT. "put && move" won't afford any more protection than using > simply "put", since info/refs is not updated if a PUT fails, so there > is no cause for concern.
That's a completely bogus reasoning. Normal operation inside the repository that was pushed into won't look at info/refs at all.
The true reason you want to avoid put-then-move is...?