Re: [PATCH 0/2] StGit patch series import

From: Junio C Hamano <gitster@pobox.com>
Date: May 25, 2009, 06:39 UTC
Message-ID: <7vocthy9df.fsf@alter.siamese.dyndns.org>
In-Reply-To: <cb7bb73a0905241603r4949abb5g1a9e861aba40c6fe@mail.gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:

> But then the name munge would not be descriptive of what the command
> does. If git am is to be left untouched, I would rather then have
> something like git import-patches that accepts patches in 'any'
> format,...

There is no need to introduce any new program, I think.

Nobody is against your teaching the "git am" callchain to accept things other than Berkeley mbox. "git am" is "import-patches" in that sense already.

You can add a conditional (perhaps triggered by a "the patches are in this format" command line option) to "git am" to alter the way it splits the input into individual pieces of e-mail, named 0001, 0002, 0003, ..., and leaves the total number of message in $dotest/last.

Currently we call "git-mailsplit" to do all of that; your new conditional will take StGIT export, and instead of calling "git-mailsplit", read the series file and process individual patch files into 0001, 0002,... that are in proper mbox format (i.e. you would need to fix the "Subject: " less title line when you do this), and leave the total number of patches in $dotest/last file.

With that change, the main loop that iterates 'while test "$this" -le "$last"' does not have to change, right?

We could for example add RMAIL format support in the same way.