git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] StGit patch series import

From
Junio C Hamano <gitster@pobox.com>
Date
May 24, 2009, 22:02 UTC
Message-ID
<7vfxeurwh0.fsf@alter.siamese.dyndns.org>
In-Reply-To
<cb7bb73a0905241443m6b5d6ba4vab438c856e47a947@mail.gmail.com>
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
Show 5 quoted lines
> That was my initial thought too, but then I realized that having the
> 'heuristics' (although a very braindead one) in mailinfo makes more
> sense because otherwise StGIT patch autodetection would only work when
> applying a whole series, and not when applying a single (or a few)
> patches.

The above is very selfish---what if somebody else wanted to add a feature to grok a non-mailbox input to the same codepath, and it is not a StGIT patch?

That is what I called "bad taste".

The same comment may apply to the rest of your response. "This hack is good enough for _my_ use case; I do not care if my change makes life harder for others to build on top of my patch" is not what I want to see.

Previous: Sverre RabbelierNext: Giuseppe Bilotta
Message 7 of 14 in “StGit patch series import”
  1. 0/2 StGit patch series importGiuseppe Bilotta, May 24, 2009
  2. Junio C HamanoMay 24, 2009
  3. Giuseppe BilottaMay 24, 2009
  4. Sverre RabbelierMay 24, 2009
  5. Giuseppe BilottaMay 24, 2009
  6. Sverre RabbelierMay 24, 2009
  7. Junio C HamanoMay 24, 2009
  8. Giuseppe BilottaMay 24, 2009
  9. Sverre RabbelierMay 24, 2009
  10. Giuseppe BilottaMay 24, 2009
  11. Sverre RabbelierMay 24, 2009
  12. Giuseppe BilottaMay 24, 2009
  13. Junio C HamanoMay 25, 2009
  14. Giuseppe BilottaMay 25, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.