git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCHv10 01/11] fast-import: Proper notes tree manipulation

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 7, 2009, 20:42 UTC
Message-ID
<7vocma1ppc.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1260185254-1523-2-git-send-email-johan@herland.net>
Johan Herland <johan@herland.net> writes:
> This patch teaches 'git fast-import' to automatically organize note objects
> in a fast-import stream into an appropriate fanout structure.

I really hate to sound like a clueless newbie, but that is what I am in the area of 'notes', so I have two questions.

 - What is the semantics of having more than one note to the same commit
   in the input stream?  Does the 'notes' part also have history and the
   latest one overwrite the earlier one by creating a new commit that
   points at the new 'notes' tree?  I've always thought of 'notes' as an
   unversioned metainfo, but I realize that versioning them would make
   sense (you can and obviously would want to inspect the story behind the
   current note attached to one particular commit).
 - If however 'notes' want to have a history, how would it interact with
   this rebalancing of the tree?  Rebalancing makes a lot of sense if the
   'notes' mechanism deals with the only one latest version because it can
   keep the optimal look-up performance.  There were some talks about
   specialized merge strategies that can be made aware of rebalancing, but
   is there a plan to deal with "git log -p notes" side, and how?
Previous: Shawn O. PearceNext: Johan Herland
Message 14 of 28 in “[RFC/PATCHv10 00/11] git notes”
  1. Johan HerlandDec 7, 2009
  2. 01/11 fast-import: Proper notes tree manipulationJohan Herland, Dec 7, 2009
  3. Shawn O. PearceDec 7, 2009
  4. Johan HerlandDec 8, 2009
  5. Shawn O. PearceDec 8, 2009
  6. Johan HerlandDec 8, 2009
  7. Johan HerlandDec 10, 2009
  8. Shawn O. PearceDec 10, 2009
  9. Johan HerlandDec 10, 2009
  10. Junio C HamanoDec 11, 2009
  11. Shawn O. PearceDec 7, 2009
  12. Johan HerlandDec 8, 2009
  13. Shawn O. PearceDec 8, 2009
  14. Junio C HamanoDec 7, 2009
  15. Johan HerlandDec 8, 2009
  16. 02/11 Rename t9301 to t9350, to make room for more fast-import testsJohan Herland, Dec 7, 2009
  17. 03/11 Add more testcases to test fast-import of notesJohan Herland, Dec 7, 2009
  18. 04/11 Minor style fixes to notes.cJohan Herland, Dec 7, 2009
  19. 05/11 Notes API: get_commit_notes() -> format_note() + remove the commit restrictionJohan Herland, Dec 7, 2009
  20. 06/11 Notes API: init_notes(): Initialize the notes tree from the given notes refJohan Herland, Dec 7, 2009
  21. 07/11 Notes API: add_note(): Add note objects to the internal notes tree structureJohan Herland, Dec 7, 2009
  22. 08/11 Notes API: get_note(): Return the note annotating the given objectJohan Herland, Dec 7, 2009
  23. Junio C HamanoDec 7, 2009
  24. Johan HerlandDec 8, 2009
  25. 09/11 Notes API: for_each_note(): Traverse the entire notes tree with a callbackJohan Herland, Dec 7, 2009
  26. 10/11 Notes API: Allow multiple concurrent notes trees with new struct notes_treeJohan Herland, Dec 7, 2009
  27. 11/11 Refactor notes concatenation into a flexible interface for combining notesJohan Herland, Dec 7, 2009
  28. Junio C HamanoDec 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.