Re: [RFC/PATCHv10 01/11] fast-import: Proper notes tree manipulation
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Dec 7, 2009, 16:43 UTC
- Message-ID
- <20091207164311.GE17173@spearce.org>
- In-Reply-To
- <1260185254-1523-2-git-send-email-johan@herland.net>
Johan Herland <johan@herland.net> wrote:
Show 14 quoted lines
> +static unsigned char convert_num_notes_to_fanout(uintmax_t num_notes)
> +{
> + unsigned char fanout = 0;
> + while ((num_notes >>= 8))
> + fanout++;
> + return fanout;
> +}
> +
> +static void construct_path_with_fanout(const char *hex_sha1,
> + unsigned char fanout, char *path)
> +{
> + unsigned int i = 0, j = 0;
> + if (fanout >= 20)
> + die("Too large fanout (%u)", fanout);Shouldn't convert_num_notes_to_fanout have a guard to prevent this case from happening?
-- Shawn.