Re: [PATCHv3 5/6] fast-export: Fix output order of D/F changes

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 8, 2010, 06:04 UTC
Message-ID: <7voceiqzk3.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTiklqqxUhTBd4In-VQed_SMQ6X0nk2j2ysE20bmD@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

Show 5 quoted lines

>>> We correct the order by instructing the diff_tree machinery to compare
>>> entries using df_name_compare instead of base_name_compare.
>
> Doh! Yep, you're right.  My patch would not handle that case
> correctly.

If all you want is to force a particular order of paths in the output (e.g. depth first) in this one single application, the cleanest way might be to let the diffcore do its work and at the very end sort the elements in the diff_queued_diff to your liking (c.f. diffcore_fix_diff_index() that uses diffnamecmp() to sort the list).