git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/5] log: decorate grafted commits with "grafted"

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 18, 2011, 18:10 UTC
Message-ID
<7vobzma435.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1313670578-2939-5-git-send-email-pclouds@gmail.com>

I think this makes a lot more sense than the other option of looking up graft points every time, as we expect only a handful of grafts, if any, exist in a repository.

If you have, on the other hand, tons of historical graft points, and you are viewing only near the tip (e.g. "log -20"), this implimentation still calls lookup_commit() for all those historical graft points that are likely to be scattered further back in the packfile, and the performance may suffer. But that is what it means when we say that we are optimized for use case where only a handful of grafts exist, so it is not something that we worry about too much.

Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 11 of 14 in “log: decorate grafted commits with "grafted"”
  1. log: decorate grafted commits with "grafted"Nguyễn Thái Ngọc Duy, Aug 17, 2011
  2. Junio C HamanoAug 17, 2011
  3. Nguyen Thai Ngoc DuyAug 18, 2011
  4. 0/5 Decorate grafts and replacesNguyễn Thái Ngọc Duy, Aug 18, 2011
  5. 1/5 decoration: do not mis-decorate refs with same prefixNguyễn Thái Ngọc Duy, Aug 18, 2011
  6. Junio C HamanoAug 18, 2011
  7. 2/5 Add for_each_commit_graft() to iterate all graftsNguyễn Thái Ngọc Duy, Aug 18, 2011
  8. 3/5 Move write_shallow_commits to fetch-pack.cNguyễn Thái Ngọc Duy, Aug 18, 2011
  9. Junio C HamanoAug 18, 2011
  10. 4/5 log: decorate grafted commits with "grafted"Nguyễn Thái Ngọc Duy, Aug 18, 2011
  11. Junio C HamanoAug 18, 2011
  12. 5/5 log: decorate "replaced" on to replaced commitsNguyễn Thái Ngọc Duy, Aug 18, 2011
  13. Junio C HamanoAug 18, 2011
  14. log: decorate "replaced" on to replaced commitsNguyễn Thái Ngọc Duy, Aug 19, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.