Re: [PATCH] log: decorate grafted commits with "grafted"

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 17, 2011, 18:48 UTC
Message-ID: <7v8vqreuwk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1313593326-12077-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 7 quoted lines

> @@ -638,6 +640,9 @@ int log_tree_commit(struct rev_info *opt, struct commit *commit)
>  	log.parent = NULL;
>  	opt->loginfo = &log;
>  
> +	if (!commit->parents && lookup_commit_graft(commit->object.sha1))
> +		add_name_decoration(DECORATION_GRAFTED, "grafted",
> +				    &commit->object);

I am not very enthused about this change.

We have already looked up the commit when we parsed it, and then we again have to call lookup_commit_graft() which would yield false for most of the commits?

Does this work with replacements and shallows, by the way?