git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v17 1/7] bisect: move argument parsing before state modification.

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 7, 2011, 11:29 UTC
Message-ID
<7vobyw4mkv.fsf@alter.siamese.dyndns.org>
In-Reply-To
<201109070816.16655.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> writes:
Show 10 quoted lines
> If we start bisecting like this:
>
> $ git bisect start HEAD HEAD~20
>
> and then we decide that it was not optimum and we want to start again like 
> this:
>
> $ git bisect start HEAD HEAD~6
>
> then issuing the latter command might not work as it did before this patch.

I didn't even know the above was supposed to work. It may have worked, but I think it was not by design but merely by accident. Besides, wouldn't it be the same to say "git bisect good" to further limit the suspect range, instead of giving the second, seemingly nested, "bisect start" that is not really nesting, which only confuses the users?

Having said that, if you can resurrect the old behaviour without too much code churn, I wouldn't mind to look at the patch, but I am not sure if it is worth it.

Previous: Christian CouderNext: Johannes Sixt
Message 4 of 12 in “bisect: Add support for --no-checkout option”
  1. 0/7 bisect: Add support for --no-checkout optionJon Seymour, Aug 4, 2011
  2. 1/7 bisect: move argument parsing before state modification.Jon Seymour, Aug 4, 2011
  3. Christian CouderSep 7, 2011
  4. Junio C HamanoSep 7, 2011
  5. Johannes SixtSep 7, 2011
  6. Jon SeymourSep 8, 2011
  7. 2/7 bisect: use && to connect statements that are deferred with eval.Jon Seymour, Aug 4, 2011
  8. 3/7 bisect: add tests to document expected behaviour in presence of broken trees.Jon Seymour, Aug 4, 2011
  9. 4/7 bisect: introduce support for --no-checkout option.Jon Seymour, Aug 4, 2011
  10. 5/7 bisect: introduce --no-checkout support into porcelain.Jon Seymour, Aug 4, 2011
  11. 6/7 bisect: add tests for the --no-checkout option.Jon Seymour, Aug 4, 2011
  12. 7/7 bisect: add documentation for --no-checkout option.Jon Seymour, Aug 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.