[PATCH v17 2/7] bisect: use && to connect statements that are deferred with eval.

From: Jon Seymour <jon.seymour@gmail.com>
Date: Aug 4, 2011, 12:00 UTC
Message-ID: <1312459263-16911-3-git-send-email-jon.seymour@gmail.com>
In-Reply-To: <1312459263-16911-1-git-send-email-jon.seymour@gmail.com>

Christian Couder pointed out that the existing eval strategy swallows an initial non-zero return. Using && to connect the statements should fix this.

Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
---
 git-bisect.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/git-bisect.sh b/git-bisect.sh
index 20f6dd5..a44ffe1 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -86,7 +86,7 @@ bisect_start() {
 		0) state='bad' ; bad_seen=1 ;;
 		*) state='good' ;;
 		esac
-		eval="$eval bisect_write '$state' '$rev' 'nolog'; "
+		eval="$eval bisect_write '$state' '$rev' 'nolog' &&"
 		shift
 		;;
 	    esac
@@ -145,7 +145,7 @@ bisect_start() {
 	#
 	echo "$start_head" >"$GIT_DIR/BISECT_START" &&
 	git rev-parse --sq-quote "$@" >"$GIT_DIR/BISECT_NAMES" &&
-	eval "$eval" &&
+	eval "$eval true" &&
 	echo "git bisect start$orig_args" >>"$GIT_DIR/BISECT_LOG" || exit
 	#
 	# Check if we can proceed to the next bisect state.

-- 
1.7.6.353.g50d6f