git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git blame only current branch

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 13, 2011, 05:47 UTC
Message-ID
<7vobvdvx9c.fsf@alter.siamese.dyndns.org>
In-Reply-To
<8739cpteat.fsf@gmail.com>
Vijay Lakshminarayanan <laksvij@gmail.com> writes:
Show 10 quoted lines
> The code reads fine when there's no numeral 1 around but now it doesn't
> read well.  I think refactoring
>
>     struct commit_list *l
>
> to 
>
>     struct commit_list *lst
>
> is justified.  Thoughts?
Not justified at all.

What is "lst" and why is it not spelled "list"? It is a disease to drop vowels when you do not have to.

If I were to name a new variable that points at one element of a linked list and is used to walk the list (surprise!) "element" or perhaps "elem" for short, but in the context of that short function I honestly do not see much need for such a naming. The variable is extremely short-lived and there is no room for confusion.

Previous: Jeff KingNext: Vijay Lakshminarayanan
Message 7 of 10 in “Git blame only current branch”
  1. Stephen BashDec 12, 2011
  2. Jeff KingDec 12, 2011
  3. Stephen BashDec 12, 2011
  4. andreas.t.auer_gtml_37453@ursus.ath.cxDec 12, 2011
  5. Vijay LakshminarayananDec 13, 2011
  6. Jeff KingDec 13, 2011
  7. Junio C HamanoDec 13, 2011
  8. Vijay LakshminarayananDec 13, 2011
  9. Frans KlaverDec 13, 2011
  10. Junio C HamanoDec 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.