From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 13 Dec 2011 05:47:11 GMT
Subject: Re: Git blame only current branch
Message-ID: <7vobvdvx9c.fsf@alter.siamese.dyndns.org>
In-Reply-To: <8739cpteat.fsf@gmail.com>

Vijay Lakshminarayanan <laksvij@gmail.com> writes:

> The code reads fine when there's no numeral 1 around but now it doesn't
> read well.  I think refactoring
>
>     struct commit_list *l
>
> to 
>
>     struct commit_list *lst
>
> is justified.  Thoughts?

Not justified at all.

What is "lst" and why is it not spelled "list"?  It is a disease to drop
vowels when you do not have to.

If I were to name a new variable that points at one element of a linked
list and is used to walk the list (surprise!) "element" or perhaps "elem"
for short, but in the context of that short function I honestly do not see
much need for such a naming. The variable is extremely short-lived and
there is no room for confusion.