git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] diff: refactor the word-diff setup from builtin_diff_cmd

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 14, 2012, 19:26 UTC
Message-ID
<7vobrzoug4.fsf@alter.siamese.dyndns.org>
In-Reply-To
<9f2f3a870a8d88850444090318647f3c7b8c0743.1331749299.git.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
> Quite a chunk of builtin_diff_cmd deals with word-diff setup, defaults
> and such.  This makes the function a bit hard to read, but is also
> asymmetric because the corresponding teardown lives in free_diff_words_data
> already.
Yay!  "A bit hard to read" is a gross understatement ;-)

Whether the series fixes a bug of not, this alone makes the patch worthwhile to look.

Thanks.
Previous: Thomas RastNext: Thomas Rast
Message 3 of 10 in “Demonstrate a bug in --word-diff where diff.*.wordregex is "sticky"”
  1. 1/3 Demonstrate a bug in --word-diff where diff.*.wordregex is "sticky"Thomas Rast, Mar 14, 2012
  2. 2/3 diff: refactor the word-diff setup from builtin_diff_cmdThomas Rast, Mar 14, 2012
  3. Junio C HamanoMar 14, 2012
  4. 3/3 diff: tweak a _copy_ of diff_options with word-diffThomas Rast, Mar 14, 2012
  5. Junio C HamanoMar 14, 2012
  6. Junio C HamanoMar 14, 2012
  7. 1/3 Demonstrate a bug in --word-diff where diff.*.wordregex is "sticky"Johannes Sixt, Mar 14, 2012
  8. Stefano LattariniMar 14, 2012
  9. Junio C HamanoMar 14, 2012
  10. Johannes SixtMar 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.