git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/3] Demonstrate a bug in --word-diff where diff.*.wordregex is "sticky"

From
Stefano Lattarini <stefano.lattarini@gmail.com>
Date
Mar 14, 2012, 21:03 UTC
Message-ID
<4F610788.3090604@gmail.com>
In-Reply-To
<4F60F67D.9050003@kdbg.org>
On 03/14/2012 08:50 PM, Johannes Sixt wrote:
Show 14 quoted lines
> The test case applies a custom wordRegex to one file in a diff, and expects
> that the default word splitting applies to the second file in the diff.
> But the custom wordRegex is also incorrectly used for the second file.
> 
> Helped-by: Thomas Rast <trast@student.ethz.ch>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> Changes in this round, where I do not resend 2/3 and 3/3:
> 
> - Use test_unconfig.
> - Use compare_diff_patch to check the result.
> - Fix a broken && chain at the end of the last test.
> - Name the files a.tex and z.tex as per your suggestion.
>
But Junio suggested using 'z.txt' (not 'z.tex'); quoting his last message:
  The use of files "a" and "z" as an example of pair of a tex and non tex
  input makes the test look overly artificial (why not a.tex vs z.txt or
  something?), but other than that, looks cleanly done.
Regards,
  Stefano
Previous: Johannes SixtNext: Junio C Hamano
Message 8 of 10 in “Demonstrate a bug in --word-diff where diff.*.wordregex is "sticky"”
  1. 1/3 Demonstrate a bug in --word-diff where diff.*.wordregex is "sticky"Thomas Rast, Mar 14, 2012
  2. 2/3 diff: refactor the word-diff setup from builtin_diff_cmdThomas Rast, Mar 14, 2012
  3. Junio C HamanoMar 14, 2012
  4. 3/3 diff: tweak a _copy_ of diff_options with word-diffThomas Rast, Mar 14, 2012
  5. Junio C HamanoMar 14, 2012
  6. Junio C HamanoMar 14, 2012
  7. 1/3 Demonstrate a bug in --word-diff where diff.*.wordregex is "sticky"Johannes Sixt, Mar 14, 2012
  8. Stefano LattariniMar 14, 2012
  9. Junio C HamanoMar 14, 2012
  10. Johannes SixtMar 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.