Re: [PATCH v2 1/2] t0303: immediately bail out w/o GIT_TEST_CREDENTIAL_HELPER

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 15, 2012, 17:50 UTC
Message-ID: <7vobrxkb3m.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120315132642.GA8945@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 19 quoted lines

> On Thu, Mar 15, 2012 at 09:24:28AM -0400, Jeff King wrote:
>
>> > >> 	make GIT_TEST_CREDENTIAL_HELPER=cache T=t0303-*.sh prove
>> > >> 
>> > >> seems to get stuck forever.
>> > >
>> > > It's because t0303 is the generic "test any helper" script, and does not
>> > > know how to clean up the credential-cache daemon. So the daemon sticks
>> > > around, holding onto a file descriptor that causes prove to hang.
>> > 
>> > And the reason why "sh t0303-*.sh" version does not have this problem is...?
>> [long-winded explanation from me]
>
> Oops. I read this as "why does t0301 not have the problem?". So ignore
> everything I said.
>
> The reason why running it via sh works is that we leave the daemon
> running in both cases, but only prove actually cares about the leaked
> file descriptor and blocks.

Ah, OK, the last part was what I was missing.  Thanks for a clarification.