Re: [PATCH v2 1/2] t0303: immediately bail out w/o GIT_TEST_CREDENTIAL_HELPER

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Mar 15, 2012, 10:44 UTC
Message-ID: <4F61C828.8060506@in.waw.pl>
In-Reply-To: <7vk42ml5er.fsf@alter.siamese.dyndns.org>

On 03/15/2012 07:55 AM, Junio C Hamano wrote:

Show 18 quoted lines

> Jeff King<peff@peff.net>  writes:
>
>> On Wed, Mar 14, 2012 at 03:17:28PM -0700, Junio C Hamano wrote:
>>> This is probably not related to your patch, but
>>>
>>> 	GIT_TEST_CREDENTIAL_HELPER=cache sh t0303-*.sh
>>>
>>> passes OK for me while
>>>
>>> 	make GIT_TEST_CREDENTIAL_HELPER=cache T=t0303-*.sh prove
>>>
>>> seems to get stuck forever.
>>
>> It's because t0303 is the generic "test any helper" script, and does not
>> know how to clean up the credential-cache daemon. So the daemon sticks
>> around, holding onto a file descriptor that causes prove to hang.
>
> And the reason why "sh t0303-*.sh" version does not have this problem is...?

It does :)

In both cases git-credential-cache--daemon is running. It is stuck in poll() with a timeout of 30*1000 ms (credentail-cache--daemon.c:175). When running without prove, it is left in the background and terminates after 30 s. When running under prove, prove waits for 30 seconds for the process to end and then terminates.

I think that this delay is OK, as it happens only when running an explicitly requested test, and only under prove.

Zbyszek