Re: [PATCH v3 0/7] diff stat calculation adjustments

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 16, 2012, 19:30 UTC
Message-ID: <7vobqrtqxj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1334573095-32286-1-git-send-email-lucian.poston@gmail.com>

Lucian Poston <lucian.poston@gmail.com> writes:

> I broke the patch series up into smaller patches. Hopefully this makes the
> intent of the changes easier to follow.
>
> Zbigniew's tests were added as PATCH 1/7.

Thanks. Overall it looks nicely done, except that the structure of the series may want a few squashing, moving and use of test_expect_failure that later turns into test_expect_success.

When I learned from you that you will be rerolling, I was expecting to see the other series, i.e.

 * lp/maint-diff-three-dash-with-graph (2012-03-20) 3 commits
  - t4202: add test for "log --graph --stat -p" separator lines
  - log --graph: fix break in graph lines
  - log --graph --stat: three-dash separator should come after graph lines

but I think this was $gmane/193490 split into three and didn't have anything controversial.

I'll merge it to 'next'.

Thanks.