git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 3/7] Adjust stat width calculations to take --graph output into account

From
Lucian Poston <lucian.poston@gmail.com>
Date
Apr 16, 2012, 10:44 UTC
Message-ID
<1334573095-32286-4-git-send-email-lucian.poston@gmail.com>
In-Reply-To
<1334573095-32286-1-git-send-email-lucian.poston@gmail.com>

The recent change to compute the width of diff --stat did not take into consideration the output from --graph. The consequence is that when both options are used, e.g. in 'log --stat --graph', the lines are too long.

Adjust stat width calculations to take --graph output into account.
Signed-off-by: Lucian Poston <lucian.poston@gmail.com>
---
 diff.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/diff.c b/diff.c
index 377ec1e..0b61cf7 100644
--- a/diff.c
+++ b/diff.c
@@ -1445,7 +1445,7 @@ static void show_stats(struct diffstat_t *data, struct diff_options *options)
 	 */
 
 	if (options->stat_width == -1)
-		width = term_columns();
+		width = term_columns() - options->output_prefix_length;
 	else
 		width = options->stat_width ? options->stat_width : 80;
 
-- 
1.7.3.4
Previous: Lucian PostonNext: Lucian Poston
Message 6 of 15 in “diff stat calculation adjustments”
  1. 0/7 diff stat calculation adjustmentsLucian Poston, Apr 16, 2012
  2. 1/7 t4052: test --stat output with --graphLucian Poston, Apr 16, 2012
  3. 2/7 Add output_prefix_length to diff_optionsLucian Poston, Apr 16, 2012
  4. Junio C HamanoApr 16, 2012
  5. Lucian PostonApr 18, 2012
  6. 3/7 Adjust stat width calculations to take --graph output into accountLucian Poston, Apr 16, 2012
  7. 4/7 t4052: Adjust --graph --stat output for prefixesLucian Poston, Apr 16, 2012
  8. Junio C HamanoApr 16, 2012
  9. Lucian PostonApr 18, 2012
  10. 5/7 t4052: Add tests to illustrate issues with restrictive COLUMNSLucian Poston, Apr 16, 2012
  11. Junio C HamanoApr 16, 2012
  12. Lucian PostonApr 18, 2012
  13. 6/7 Prevent graph_width of diff stat from falling below minLucian Poston, Apr 16, 2012
  14. 7/7 t4052: Adjust --stat output for minimum graph_widthLucian Poston, Apr 16, 2012
  15. Junio C HamanoApr 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.