git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] parse-options: introduce parse_subcommands

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 6, 2012, 17:26 UTC
Message-ID
<7vobowmjwr.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CALkWK0nuJ2VrAUD5PsfnZzO5yDgB+h4xn8g=CTqmUvJ8DOdPNQ@mail.gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
Show 5 quoted lines
>> It looks like a static version of string_list_lookup() and does not
>> have much reason to tie it to "subcommand".
>
> How so?  I can use a string_list to keep subcommand->name and stuff
> the callback into util.  Where do I put subcommand->help then?

A string_list is a mapping from a string to an arbitrary piece of data; there is nothing that stops you from placing a pointer to a structure in its util field.

> I agree that there's no reason to tie it to subcommand though.

Yeah, if it were a generic API for a mapping from a string to an arbitrary piece of data that is determined at compile time, it would be a useful addition, and at that point, it is misleading to call that a "parse-subcommand" API. It is just a look-up mechansim in a fixed table keyed by strings.

Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 4 of 13 in “parse-options: introduce parse_subcommands”
  1. parse-options: introduce parse_subcommandsRamkumar Ramachandra, Jun 4, 2012
  2. Junio C HamanoJun 4, 2012
  3. Ramkumar RamachandraJun 6, 2012
  4. Junio C HamanoJun 6, 2012
  5. [RFC] notes: attach help text to subcommandsRamkumar Ramachandra, Jun 8, 2012
  6. Junio C HamanoJun 8, 2012
  7. notes: attach help text to subcommandsRamkumar Ramachandra, Jun 8, 2012
  8. Jonathan NiederJun 8, 2012
  9. Felipe ContrerasJun 8, 2012
  10. Ramkumar RamachandraJun 8, 2012
  11. Felipe ContrerasJun 13, 2012
  12. Junio C HamanoJun 8, 2012
  13. Jonathan NiederJun 5, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.