Re: [RFC/PATCH] parse-options: introduce parse_subcommands
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jun 5, 2012, 23:32 UTC
- Message-ID
- <20120605233257.GG3619@burratino>
- In-Reply-To
- <1338802534-32394-1-git-send-email-artagnon@gmail.com>
Hi,
Ramkumar Ramachandra wrote:
Show 5 quoted lines
> $ git notes foo > error: Unknown subcommand: foo > usage: git notes [--ref <notes_ref>] [list [<object>]] > or: git notes [--ref <notes_ref>] add [-f] [-m <msg> | -F <file> | (-c | -C) <object>] [<object>] > or: git notes [--ref <notes_ref>] copy [-f] <from-object> <to-object>
[...]
Show 17 quoted lines
> is replaced by a more helpful: > > $ git notes foo > error: unknown subcommand: foo > usage: git notes [<options>] [<subcommand>] [<options>] [<object>..] > > available subcommands: > list list notes for given object > add add notes for given object > copy copy notes for first object onto second object > append append notes to existing object > edit edit notes for given object > show show notes for given object > merge merge given notes ref into current notes ref > remove remove notes for given objects > prune remove all notes for non-existing/unreachable objects > get-ref print the current notes ref
The goal looks good. As Junio said, the code looks simplifiable.
Hope that helps, Jonathan