git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] Using a bit more decoration

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 9, 2013, 04:37 UTC
Message-ID
<7vobdotj41.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130409035126.GA17319@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
> Neat. Reading through, I didn't notice anything obviously wrong with any
> of the patches (though there is one gcc warning, which I'll respond to
> separately).
>
> It does make me a little nervous to have code that almost never gets
> exercised (i.e., when indegree is really high, or a large number of
> encodings). It seems like a bug waiting to happen when somebody does hit
> that condition.

One round of work-in-progress code I had when you asked what I was up to did have that off-by-one bug ;-) set_indegree() had to spill into the hash when storing 255 (i.e. exactly the value of LIMIT) but I was spilling strting from 256, so an entry with 255 children looked into the hash, finding nothing and said "I am done" X-<.

I haven't bothered to try the "more than 256 encodings", but with the likely off-by-one in mind, I think I was being careful enough.

Previous: Junio C Hamano
Message 15 of 15 in “decorate: add "clear_decoration()"”
  1. 2/2 decorate: add "clear_decoration()"Junio C Hamano, Apr 8, 2013
  2. Jeff KingApr 8, 2013
  3. Junio C HamanoApr 8, 2013
  4. 0/3 Using a bit more decorationJunio C Hamano, Apr 8, 2013
  5. 1/3 commit: shrink "indegree" fieldJunio C Hamano, Apr 8, 2013
  6. Jeff KingApr 9, 2013
  7. 2/3 commit: rename parse_commit_date()Junio C Hamano, Apr 8, 2013
  8. 3/3 commit: add get_commit_encoding()Junio C Hamano, Apr 8, 2013
  9. Jeff KingApr 9, 2013
  10. Junio C HamanoApr 9, 2013
  11. Jeff KingApr 9, 2013
  12. Junio C HamanoApr 9, 2013
  13. Jeff KingApr 9, 2013
  14. Junio C HamanoApr 9, 2013
  15. Junio C HamanoApr 9, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.