git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] decorate: add "clear_decoration()"

From
Jeff King <peff@peff.net>
Date
Apr 8, 2013, 21:09 UTC
Message-ID
<20130408210903.GC9649@sigill.intra.peff.net>
In-Reply-To
<7v1ual35xi.fsf@alter.siamese.dyndns.org>
On Sun, Apr 07, 2013 at 11:14:17PM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> So far, all the users of the decoration API used decoration that
> only grows and discarded at the end of the program execution.
> 
> Introduce for_each_decoration() that lets the caller iterate over
> all defined decorations and use it to implement clear_decoration()
> function.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Both this and the first patch look good to me. I had documented api-decorate long ago as part of the cache-metadata-on-disk series (it was built on generic maps, which I also refactored decorate on top of). But I didn't see anything in my version that was missing from yours (in fact, it was much sparser, because it just referred to the generic map api, which we never merged).

Out of curiosity: where is the patch 3 that presumably led you to wanting these?

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 15 in “decorate: add "clear_decoration()"”
  1. 2/2 decorate: add "clear_decoration()"Junio C Hamano, Apr 8, 2013
  2. Jeff KingApr 8, 2013
  3. Junio C HamanoApr 8, 2013
  4. 0/3 Using a bit more decorationJunio C Hamano, Apr 8, 2013
  5. 1/3 commit: shrink "indegree" fieldJunio C Hamano, Apr 8, 2013
  6. Jeff KingApr 9, 2013
  7. 2/3 commit: rename parse_commit_date()Junio C Hamano, Apr 8, 2013
  8. 3/3 commit: add get_commit_encoding()Junio C Hamano, Apr 8, 2013
  9. Jeff KingApr 9, 2013
  10. Junio C HamanoApr 9, 2013
  11. Jeff KingApr 9, 2013
  12. Junio C HamanoApr 9, 2013
  13. Jeff KingApr 9, 2013
  14. Junio C HamanoApr 9, 2013
  15. Junio C HamanoApr 9, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.