Re: [PATCH] teach the user to be nice to git and let him say please sometimes

From: Junio C Hamano <gitster@pobox.com>
Date: May 12, 2013, 21:19 UTC
Message-ID: <7vobcfvqu1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130511201928.GA22938@book.hvoigt.net>

Heiko Voigt <hvoigt@hvoigt.net> writes:

Show 8 quoted lines

> Since ages we do not care about our program enough. Lets not treat them
> as slaves anymore and say please.
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
> Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
> Signed-off-by: Johan Herland <johan@herland.net>

So these were the ones present on the dev-day?

I actually would have expected, from the "please" title, the opposite, us saying "please" to the user, either once in a while in the advice messages we give to them, or perhaps in the en_POLITE locale ;-)

Show 9 quoted lines

>  .gitignore                       |  1 +
>  Makefile                         |  1 +
>  builtin.h                        |  1 +
>  builtin/config.c                 | 23 ++-----------------
>  builtin/please.c                 |  9 ++++++++
>  cache.h                          |  1 +
>  config.c                         | 23 +++++++++++++++++++
>  contrib/completion/git-prompt.sh |  5 +++-
>  git.c                            | 49 +++++++++++++++++++++++++++++++++++++++-

There is no test to protect this feature from future breakages?