Re: Re: [PATCH] teach the user to be nice to git and let him say please sometimes

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: May 13, 2013, 13:44 UTC
Message-ID: <20130513134415.GB3561@book-mint>
In-Reply-To: <7vobcfvqu1.fsf@alter.siamese.dyndns.org>

Hi,

On Sun, May 12, 2013 at 02:19:34PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Heiko Voigt <hvoigt@hvoigt.net> writes:
> 
> > Since ages we do not care about our program enough. Lets not treat them
> > as slaves anymore and say please.
> >
> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> > Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> > Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
> > Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
> > Signed-off-by: Johan Herland <johan@herland.net>
> 
> So these were the ones present on the dev-day?

No this was just a random sample of the ones sitting at the same beer garden table that this feature was implemented on.

> I actually would have expected, from the "please" title, the
> opposite, us saying "please" to the user, either once in a while in
> the advice messages we give to them, or perhaps in the en_POLITE
> locale ;-)

The en_POLITE is also a nice idea :-) We could split up the work on the translations amongst all people joining a git meetup.

Show 11 quoted lines

> >  .gitignore                       |  1 +
> >  Makefile                         |  1 +
> >  builtin.h                        |  1 +
> >  builtin/config.c                 | 23 ++-----------------
> >  builtin/please.c                 |  9 ++++++++
> >  cache.h                          |  1 +
> >  config.c                         | 23 +++++++++++++++++++
> >  contrib/completion/git-prompt.sh |  5 +++-
> >  git.c                            | 49 +++++++++++++++++++++++++++++++++++++++-
> 
> There is no test to protect this feature from future breakages?

In fact the whole testsuite should fail after the first 10 tests if you said please right before running it. So since battery life is short and this feature so important we did not bother to fix that. We already had enough please complaints during intermediate commits and entering the signed-off messages. It is really annoying, you should try this patch! ;-) And it is especially unuseful when you are committing using git gui.

Cheers Heiko