Re: [PATCH] git-clone.txt: remove the restriction on pushing from a shallow clone

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 15, 2013, 15:31 UTC
Message-ID: <7voba3dem1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACsJy8DELmhBwBCk9hmg4EpQxGeCRDPaSEr5rYp=CiMjq8j54Q@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 12 quoted lines

> On Mon, Jul 15, 2013 at 8:01 AM, Duy Nguyen <pclouds@gmail.com> wrote:
>>> Also, the sender may have cloned from the receiver (fully) and then
>>> fetched a different history shallowly from elsewhere.  The receiver
>>> may have no commit on that history, including the shallow-bottom.
>>>
>>
>> Hmm.. right. And the receiver needs to setup proper graft to seal the
>> shallow bottom. So it's really not safe to do pushing from a shallow
>> repo without 52fed6e
>
> Because this makes pushing from a shallow repo fall into "mostly
> works" category, I withdraw this patch.

Yeah, "reliably fails when it shouldn't" may be safer than before that patch, but the fact that you cannot push from a shallow one still remains, so we probably shouldn't tell the users to use it.