Re: [PATCH] git-clone.txt: remove the restriction on pushing from a shallow clone

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2013, 05:53 UTC
Message-ID: <7v38rkpbmr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1373607462-12836-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 9 quoted lines

> The document says one cannot push from a shallow clone. But that is
> not true (maybe it was at some point in the past). The client does not
> stop such a push nor does it give any indication to the receiver that
> this is a shallow push. If the receiver accepts it, it's in.
>
> Since 52fed6e (receive-pack: check connectivity before concluding "git
> push" - 2011-09-02), receive-pack is prepared to deal with broken
> push, a shallow push can't cause any corruption. Update the document
> to reflect that.

Err, what are these lines in builtin/receive-pack.c doing, then?

        int cmd_receive_pack(int argc, const char **argv, const char *prefix)
        {
                ...
                setup_path();

                if (!enter_repo(dir, 0))
                        die("'%s' does not appear to be a git repository", dir);

                if (is_repository_shallow())
                        die("attempt to push into a shallow repository");
                ...