Re: [PATCH] revision: add --no-full-diff command line option
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> On Wed, Dec 20, 2006 at 12:14:14AM -0800, Junio C Hamano wrote:
>
>> > I use --full-diff all the time, so this should save some typing. I can't
>> > think of a time when I wouldn't want it on, but if there is, we probably
>> > need a --no-full-diff.
>>
>> Absolutely.
>
> I took this to mean "absolutely we need --no-full-diff." :)
Modulo s/\.$/, if we were to do log.fulldiff/, yes.
Show 7 quoted lines
> I note that --full-diff sets rev->diff = 1. The log.fulldiff config
> option does not, and nor does --no-full-diff unset it. However, I'm not
> sure it makes sense to set it. Doing "git-log --full-diff" outputs an
> extra line (separating the diff from the commit log) but since we
> haven't told it any type of diff to output, the diff is blank. And if we
> had told it a type, then that would have turned on rev->diff. So I don't
> see a point in setting it.
I need to think about this one.
Junio C Hamano <junkio@cox.net>