From: Junio C Hamano Date: Wed, 20 Dec 2006 19:55:05 GMT Subject: Re: [PATCH] revision: add --no-full-diff command line option Message-ID: <7vmz5ie412.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20061220084107.GA6895@coredump.intra.peff.net> Jeff King writes: > Signed-off-by: Jeff King > --- > On Wed, Dec 20, 2006 at 12:14:14AM -0800, Junio C Hamano wrote: > >> > I use --full-diff all the time, so this should save some typing. I can't >> > think of a time when I wouldn't want it on, but if there is, we probably >> > need a --no-full-diff. >> >> Absolutely. > > I took this to mean "absolutely we need --no-full-diff." :) Modulo s/\.$/, if we were to do log.fulldiff/, yes. > I note that --full-diff sets rev->diff = 1. The log.fulldiff config > option does not, and nor does --no-full-diff unset it. However, I'm not > sure it makes sense to set it. Doing "git-log --full-diff" outputs an > extra line (separating the diff from the commit log) but since we > haven't told it any type of diff to output, the diff is blank. And if we > had told it a type, then that would have turned on rev->diff. So I don't > see a point in setting it. I need to think about this one.