git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix start_command closing cmd->out/in regardless of cmd->close_out/in

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 18, 2007, 18:52 UTC
Message-ID
<7vmytbv11m.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1195407366-1610-1-git-send-email-pkufranky@gmail.com>
Ping Yin <pkufranky@gmail.com> writes:
> When 'FILE *fp' is assigned to child_process.out and then start_command or
> run_command is run, the standard output of the child process is expected to
> be outputed to fp. However, sometimes fp is not expected to be closed since
> further IO may be still performmed on fp.

Could you clarify "However, sometimes" with a concrete codepath that has this problem in the proposed commit log message, and Sign-off your patch please?

Previous: Ping YinNext: Johannes Sixt
Message 2 of 4 in “Fix start_command closing cmd->out/in regardless of cmd->close_out/in”
  1. Fix start_command closing cmd->out/in regardless of cmd->close_out/inPing Yin, Nov 18, 2007
  2. Junio C HamanoNov 18, 2007
  3. Johannes SixtNov 19, 2007
  4. Junio C HamanoNov 19, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.