From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 18 Nov 2007 18:52:37 GMT
Subject: Re: [PATCH] Fix start_command closing cmd->out/in regardless of cmd->close_out/in
Message-ID: <7vmytbv11m.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1195407366-1610-1-git-send-email-pkufranky@gmail.com>

Ping Yin <pkufranky@gmail.com> writes:

> When 'FILE *fp' is assigned to child_process.out and then start_command or
> run_command is run, the standard output of the child process is expected to
> be outputed to fp. However, sometimes fp is not expected to be closed since
> further IO may be still performmed on fp.

Could you clarify "However, sometimes" with a concrete codepath
that has this problem in the proposed commit log message, and
Sign-off your patch please?