Re: [PATCH try 2] gitweb: Add option to put a trailing slash on pathinfo-style project URLs
Jakub Narebski <jnareb@gmail.com> writes:
Show 7 quoted lines
>> + # If you want a trailing slash on the project path (because, for
>> + # example, you have a real directory at that URL and are using
>> + # some rewrite magic to invoke gitweb), then set:
>> + # $feature{'pathinfo'}{'default'} = [1, 1];
>> +
>
> Are any disadvantages to having it always enabled?Show 5 quoted lines
>> + my @use_pathinfo = gitweb_get_feature('pathinfo');
>
> Why not name those variables for better readability?
>
> + my ($use_pathinfo, $trailing_slash) = gitweb_get_feature('pathinfo');