git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: unify boolean feature subroutines

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 16, 2008, 09:03 UTC
Message-ID
<7vmyewqypk.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1229408179-7655-1-git-send-email-kraai@ftbfs.org>

I'll queue this in 'pu' for now; it has obvious and trivial conflicts with other gitweb series that introduce new features ;-)

And regarding your follow-up patch you called "churn", I think it is probably a good idea in the longer term, although I haven't really looked at all the callers to make sure everybody would be happy.

But a change to the function signature of feature subroutines is not something I'd like to apply while other series that want to add new features are still cooking. How about doing these two patches as the first thing that goes to 'next' after 1.6.1, and then force other series rebase on top of your change? Alternatively, we could make you wait until other series do settle in 'next' and then apply your change rebased on them, but I think that is probably less optimal.

Thanks.
Previous: Matt KraaiNext: Matt Kraai
Message 10 of 13 in “gitweb: make feature_blame return a list”
  1. gitweb: make feature_blame return a listMatt Kraai, Dec 15, 2008
  2. gitweb: unify boolean feature subroutinesMatt Kraai, Dec 15, 2008
  3. Junio C HamanoDec 15, 2008
  4. Junio C HamanoDec 15, 2008
  5. Giuseppe BilottaDec 15, 2008
  6. Matt KraaiDec 16, 2008
  7. Junio C HamanoDec 16, 2008
  8. gitweb: unify boolean feature subroutinesMatt Kraai, Dec 16, 2008
  9. gitweb: pass the option name to the feature callbackMatt Kraai, Dec 16, 2008
  10. Junio C HamanoDec 16, 2008
  11. Matt KraaiDec 16, 2008
  12. Petr BaudisDec 17, 2008
  13. Junio C HamanoDec 17, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.