Re: [PATCH] gitweb: make feature_blame return a list
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 15, 2008, 22:20 UTC
- Message-ID
- <7v7i61w06k.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1229352709-4663-1-git-send-email-kraai@ftbfs.org>
Matt Kraai <kraai@ftbfs.org> writes:
Show 27 quoted lines
> The feature defaults are expected to be a list, but feature_blame was
> returning a scalar. This change makes it consistent with the other
> boolean feature subroutines.
>
> Signed-off-by: Matt Kraai <kraai@ftbfs.org>
> ---
> gitweb/gitweb.perl | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 6eb370d..145e712 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -367,12 +367,12 @@ sub feature_blame {
> my ($val) = git_get_project_config('blame', '--bool');
>
> if ($val eq 'true') {
> - return 1;
> + return (1);
> } elsif ($val eq 'false') {
> - return 0;
> + return (0);
> }
>
> - return $_[0];
> + return ($_[0]);
> }My Perl may be getting rusty, but does the above make any difference? How?