Re: [PATCH 2/3] parse-options: add PARSE_OPT_CUSTOM_ARGH for complicated argh's

From: Junio C Hamano <gitster@pobox.com>
Date: May 18, 2009, 07:57 UTC
Message-ID: <7vmy9aetc8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4A11096B.8020208@gmail.com>

Stephen Boyd <bebarino@gmail.com> writes:

> This description sounds nice ;) Is PARSE_OPT_CUSTOM_ARGH a good name? I
> was thinking maybe PARSE_OPT_MULTARGS is better?

You are asking a wrong person. I am terrible at naming things; think "rerere" ;-).

But I think custom-arghelp is much better than multargs. You are asking "use this help for argument value _literally_", so another possibility perhaps is PARSE_OPT_ARGHELP_LITERAL.

After all, there probably are many other valid reasons why you may not want "s/.*/<&>/" blindly applied to your string. One reason may be because the string describes multiple arguments, but I suspect that it is not the only one. It is better to name the option after what it does, than naming it after one sample reason why you might want to use that option.

>> Please update Documentation/technical/api-parse-options.txt as well.
>
> There's no documentation on the flags yet, but I suppose I could add that.

Thanks.