Re: [PATCH v2 2/3] git-core: Support retrieving passwords with GIT_ASKPASS

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 26, 2010, 17:50 UTC
Message-ID: <7vmxyvx4wx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4B87952F.1000902@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 9 quoted lines

> openssh treats SSH_ASKPASS as a command name and uses execlp, i.e., does a
> PATH search; no shell tricks are possible. Hence, we should *not* set
> use_shell.
>
> http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/readpass.c?rev=1.47
>
> Of course, we could define that GIT_ASKPASS is different from SSH_ASKPASS
> in this regard, but I haven't followed the discussion to know whether this
> is necessary.

It is sad that they do exec*p() on that one; it means that the users cannot supply leading set of options with CMD="cmd --initial-option".

But we should do the same as others do.

It is doubly sad that I earlier was hoping that we can run external programs specified via GIT_* uniformly via shell.