Re: [PATCH v2 2/3] git-core: Support retrieving passwords with GIT_ASKPASS

From: Frank Li <lznuaa@gmail.com>
Date: Feb 26, 2010, 10:01 UTC
Message-ID: <1976ea661002260201s75ef6185x3f89742d58f12222@mail.gmail.com>
In-Reply-To: <4B87797D.7030905@viscovery.net>

Show 6 quoted lines

>
> You handle the return value in different ways. getpass() returns a pointer
> to a static buffer, but in the 'then' branch you return an allocated
> buffer. Not that it matters a lot, though. You could add a comment that
> you are aware that the memory is leaked.
>

How about my branch also use static buffer, so there are not memory leak.

best regards Frank Li