Re: [PATCH] git-send-email: fix missing space in error message

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 29, 2011, 18:33 UTC
Message-ID: <7vmxj8x5yj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1304101404-4571-1-git-send-email-sylvain@abstraction.fr>

Sylvain Rabot <sylvain@abstraction.fr> writes:

> Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>

Please keep in mind that these individual commits will eventually need an entry added to Documentation/Relnotes/1.7.5.1.txt where I describe what bug was fixed in a single paragraph, and it almost always talks about how a bug would have been triggered so that the readers can tell if the fix would benefit them.

It would have been perfect if you wrote under what condition the user would see this error message in the body of the commit.

Show 14 quoted lines

> ---
>  git-send-email.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 76565de..98ab33a 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1091,7 +1091,7 @@ X-Mailer: git-send-email $gitversion
>  			    "VALUES: server=$smtp_server ",
>  			    "encryption=$smtp_encryption ",
>  			    "hello=$smtp_domain",
> -			    defined $smtp_server_port ? "port=$smtp_server_port" : "";
> +			    defined $smtp_server_port ? " port=$smtp_server_port" : "";

If I were writing this from scratch, I probably would have written it by having leading SP for all options, perhaps like this:

	"VALUES:",
        " option=value",
        " option=value",
        (showoption) ? " option=value" : "",
        (showoption) ? " option=value" : "",
        ...

Thanks.