Re: [PATCH] git-send-email: fix missing space in error message

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 29, 2011, 18:37 UTC
Message-ID: <7viptwx5s4.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vmxj8x5yj.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> Sylvain Rabot <sylvain@abstraction.fr> writes:
>
>> Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
>
> Please keep in mind that these individual commits will eventually need an
> entry added to Documentation/Relnotes/1.7.5.1.txt where I describe what
> bug was fixed in a single paragraph, and it almost always talks about how
> a bug would have been triggered so that the readers can tell if the fix
> would benefit them.
>
> It would have been perfect if you wrote under what condition the user
> would see this error message in the body of the commit.

Will queue this; thanks.

Author: Sylvain Rabot <sylvain@abstraction.fr>
Date:   Fri Apr 29 20:23:24 2011 +0200

    git-send-email: fix missing space in error message
    
    When the command cannot make a connection to the SMTP server the error
    message to diagnose the broken configuration is issued.  However, when an
    optional smtp-server-port is given and needs to be reported, the message
    lacked a space between "hello=<smtp-domain>" and "port=<smtp-server-port>".
    
    Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>