git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] shell: add missing initialization of argv0_path

From
Junio C Hamano <gitster@pobox.com>
Date
May 5, 2011, 16:32 UTC
Message-ID
<7vmxj19kgf.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4DC24A7F.20705@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
Show 9 quoted lines
> Am 5/5/2011 8:40, schrieb Dima Sharov:
>> According to c6dfb39 (remote-curl: add missing initialization of
>> argv0_path, 2009-10-13), stand-alone programs (non-builtins)
>> must call git_extract_argv0_path(argv[0]) in order to help builds
>> that derive the installation prefix at runtime. Without this call,
>> the program segfaults (or raises an assertion failure).
>
> Good catch! I checked PROGRAM_OBJS in Makefile, and shell.c was the only
> one remaining that did not call this function.

Thanks for an Ack; the patch was corrupt but was trivial to fix-up. Will queue.

Previous: Johannes Sixt
Message 3 of 3 in “shell: add missing initialization of argv0_path”
  1. shell: add missing initialization of argv0_pathDima Sharov, May 5, 2011
  2. Johannes SixtMay 5, 2011
  3. Junio C HamanoMay 5, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.