From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 05 May 2011 16:32:48 GMT
Subject: Re: [PATCH] shell: add missing initialization of argv0_path
Message-ID: <7vmxj19kgf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4DC24A7F.20705@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Am 5/5/2011 8:40, schrieb Dima Sharov:
>> According to c6dfb39 (remote-curl: add missing initialization of
>> argv0_path, 2009-10-13), stand-alone programs (non-builtins)
>> must call git_extract_argv0_path(argv[0]) in order to help builds
>> that derive the installation prefix at runtime. Without this call,
>> the program segfaults (or raises an assertion failure).
>
> Good catch! I checked PROGRAM_OBJS in Makefile, and shell.c was the only
> one remaining that did not call this function.

Thanks for an Ack; the patch was corrupt but was trivial to fix-up.
Will queue.