git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] only warn about ambiguous refs if stderr is a tty

From
Junio C Hamano <gitster@pobox.com>
Date
May 9, 2011, 16:33 UTC
Message-ID
<7vmxivq1fg.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110509124931.GA18197@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> Thinking on it more, I think warning is probably the only sane thing to
> do there. Having a branch with that name is just going to be confusing
> in the long run, and the sooner we start making the user aware of the
> situation, the better.
> ...
>> I think having the ambiguity warning in itself isn't the problem, it's
>> gitk not swallowing it that is.
>
> Agreed.

I agree with both of the above. It seems that the only thing we would need is to do (3) and nothing else in Erik's original list?

Show 11 quoted lines
>> So, to recap: The way I see it, these are our options:
>> 
>>  1) Discard this specific warning when stderr isn't a TTY (i.e
>>     what this patch does)
>>  2) Discard all warnings when stderr isn't a TTY
>>  3) Make gitk understand and forward warnings to the user
>>  4) Have gitk explicitly ignore ambiuous refs
>>  5) Come up with a way to disambiguate HEAD, and use that instead
>>     by default
>>  6) Force HEAD to never be ambiguous
>>  7) Leave things as they are
Previous: Jeff KingNext: Jeff King
Message 39 of 40 in “Creating remote branch called HEAD corrupts remote clones”
  1. Stephen KellyJan 17, 2011
  2. Stephen KellyJan 20, 2011
  3. Thomas RastJan 20, 2011
  4. Stephen KellyJan 20, 2011
  5. Erik Faye-LundJan 20, 2011
  6. Stephen KellyJan 20, 2011
  7. Felipe ContrerasJan 20, 2011
  8. Wesley J. LandakerJan 20, 2011
  9. Junio C HamanoJan 20, 2011
  10. Jeff KingJan 20, 2011
  11. Junio C HamanoJan 20, 2011
  12. Jeff KingJan 20, 2011
  13. Felipe ContrerasJan 20, 2011
  14. Junio C HamanoJan 21, 2011
  15. Felipe ContrerasJan 22, 2011
  16. Stephen KellyFeb 20, 2011
  17. Stephen KellyApr 26, 2011
  18. Felipe ContrerasApr 26, 2011
  19. Stephen KellyApr 27, 2011
  20. Felipe ContrerasApr 27, 2011
  21. Stephen KellyApr 27, 2011
  22. Felipe ContrerasApr 27, 2011
  23. Stephen KellyApr 27, 2011
  24. Felipe ContrerasApr 27, 2011
  25. Erik Faye-LundApr 27, 2011
  26. Erik Faye-LundApr 27, 2011
  27. Stephen KellyMay 2, 2011
  28. Erik Faye-LundMay 2, 2011
  29. Felipe ContrerasMay 3, 2011
  30. Stephen KellyMay 3, 2011
  31. Felipe ContrerasMay 3, 2011
  32. Erik Faye-LundMay 4, 2011
  33. only warn about ambiguous refs if stderr is a ttyErik Faye-Lund, May 9, 2011
  34. Jeff KingMay 9, 2011
  35. Erik Faye-LundMay 9, 2011
  36. Jeff KingMay 9, 2011
  37. Erik Faye-LundMay 9, 2011
  38. Jeff KingMay 9, 2011
  39. Junio C HamanoMay 9, 2011
  40. Jeff KingMay 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.