git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] tests: print failed test numbers at the end of the test run

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 24, 2011, 07:41 UTC
Message-ID
<7vmxg4w2fm.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4E2B1DF2.4000003@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
> Maybe I'm missing something completely obvious, but I always have a hard
> time finding out which test scripts did fail in a test run with -j30.
I run "ls -d t/trash*" for that ;-)
> +			if test $value != 0; then
> +				testnum=$(echo $file | cut -b 14-18)
> +				failed_tests="$failed_tests $testnum"
> +			fi

Somehow "cut" here feels dirty, as it hardcodes a mysterious offset that cannot be guessed without knowing what string it is cutting from by looking at t/Makefile.

	testnum=$(expr "$file" : 'test-results/\(t[0-9]*\)-')
Previous: Jens LehmannNext: Jens Lehmann
Message 2 of 9 in “tests: print failed test numbers at the end of the test run”
  1. tests: print failed test numbers at the end of the test runJens Lehmann, Jul 23, 2011
  2. Junio C HamanoJul 24, 2011
  3. tests: print failed test numbers at the end of the test runJens Lehmann, Jul 24, 2011
  4. Jeff KingJul 24, 2011
  5. Jens LehmannJul 24, 2011
  6. Sverre RabbelierJul 25, 2011
  7. Nguyen Thai Ngoc DuyJul 26, 2011
  8. Jeff KingJul 26, 2011
  9. Jeff KingJul 26, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.