From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 24 Jul 2011 07:41:33 GMT
Subject: Re: [RFC PATCH] tests: print failed test numbers at the end of the test run
Message-ID: <7vmxg4w2fm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4E2B1DF2.4000003@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

> Maybe I'm missing something completely obvious, but I always have a hard
> time finding out which test scripts did fail in a test run with -j30.

I run "ls -d t/trash*" for that ;-)

> +			if test $value != 0; then
> +				testnum=$(echo $file | cut -b 14-18)
> +				failed_tests="$failed_tests $testnum"
> +			fi

Somehow "cut" here feels dirty, as it hardcodes a mysterious offset that
cannot be guessed without knowing what string it is cutting from by
looking at t/Makefile.

	testnum=$(expr "$file" : 'test-results/\(t[0-9]*\)-')