Re: [PATCH] Support empty blob in fsck --lost-found

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 12, 2011, 01:10 UTC
Message-ID: <7vmxeabm5q.fsf@alter.siamese.dyndns.org>
In-Reply-To: <348F09EE-5EE2-4F3E-B1B1-6FD34BDBD117@bjhargrave.com>

BJ Hargrave <bj@bjhargrave.com> writes:

Show 14 quoted lines

> On Sep 11, 2011, at 16:43 , Junio C Hamano wrote:
>
>> Funny.
>> 
>> I am sure we fixed a similar breakage elsewhere a few years ago, by
>> swapping the size and nmemb to the calls (i.e. instead of writing one
>> block of "size" bytes, you could write "size" blocks of 1-byte) and making
>> sure fwrite() reports the number of items. IOW
>> 
>> 	if (buf && fwrite(buf, 1, size, f) != size)
>> 		die_errno("Could not write '%s'", filename);
>> 
>
> Do you want me to resubmit the patch using this technique instead of the size > 0 check?

Not really.

I am not sure when/why we would try to write an empty blob out to begin with...