Re: [PATCH] Support empty blob in fsck --lost-found
On Sep 11, 2011, at 16:43 , Junio C Hamano wrote:
Show 10 quoted lines
> Funny.
>
> I am sure we fixed a similar breakage elsewhere a few years ago, by
> swapping the size and nmemb to the calls (i.e. instead of writing one
> block of "size" bytes, you could write "size" blocks of 1-byte) and making
> sure fwrite() reports the number of items. IOW
>
> if (buf && fwrite(buf, 1, size, f) != size)
> die_errno("Could not write '%s'", filename);
> Do you want me to resubmit the patch using this technique instead of the size > 0 check?
--
BJ
BJ Hargrave <bj@bjhargrave.com>