git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: provide a way to customize html headers

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 21, 2011, 00:37 UTC
Message-ID
<7vmxcv89jl.fsf@alter.siamese.dyndns.org>
In-Reply-To
<201110210046.34679.lenaic@lhuard.fr.eu.org>
Lénaïc Huard <lenaic@lhuard.fr.eu.org> writes:
> +GITWEB_SITE_HTMLHEADER =
>  GITWEB_SITE_HEADER =
>  GITWEB_SITE_FOOTER =

Is it just me or does the inconsistency between the existing two variables and this new one with a very similar name stand out like a sore something?

It might have been better if GITWEB_SITE_(HEADER|FOOTER) were named with "_FILE" suffix, but as long as we consider/declare insert_file is the norm and in-place inclusion of mini-string is an oddball, it is sufficient to call this GITWEB_SITE_HTML_HEAD_STRING to avoid confusion?

Perhaps GITWEB_SITE_HEADER_STRING and GITWEB_SITE_FOOTER_STRING might turn out to be useful in the future for in-place inclusion of mini-strings, and when that happens, you two would thank me for this suggestion ;-)

Previous: Lénaïc HuardNext: Lénaïc Huard
Message 4 of 6 in “Re: [PATCH] gitweb: provide a way to customize html headers”
  1. Lénaïc HuardOct 17, 2011
  2. Jakub NarebskiOct 17, 2011
  3. Lénaïc HuardOct 20, 2011
  4. Junio C HamanoOct 21, 2011
  5. Lénaïc HuardOct 21, 2011
  6. Jakub NarebskiOct 21, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.