Re: [PATCH] Add MYMETA.json to perl/.gitignore
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 29, 2011, 06:58 UTC
- Message-ID
- <7vmxabyiby.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7vty4kx7ol.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 8 quoted lines
> Jack Nagel <jacknagel@gmail.com> writes: > >> ExtUtils::MakeMaker generates MYMETA.json in addition to MYMETA.yml >> since version 6.57_07. As it suggests, it is just meta information about > > Are we better off ignoring MYMETA.* instead, so that we won't get affected > when they start dropping new cruft with the same information in yet more > different formats?
Just to make sure there is no misunderstanding. The above is _not_ a rhetorical question that implies that I _think_ the patch should instead change the existing "MYMETA.yml" to "MYMETA.*" without adding a new entry to ignore "MYMETA.json". It is a pure question, and a valid answer could be "I checked with Perl people and they promise they won't be adding any more MYMETA.foo left and right with new MakeMaker releases", in which case the original patch is absolutely the right thing to do.
I am simply asking because I do not know.
Show 19 quoted lines
> >> the build and is cleaned up with 'make clean', so it should be ignored. >> >> Signed-off-by: Jack Nagel <jacknagel@gmail.com> >> --- >> perl/.gitignore | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/perl/.gitignore b/perl/.gitignore >> index 9235e73..d5c6e22 100644 >> --- a/perl/.gitignore >> +++ b/perl/.gitignore >> @@ -1,5 +1,6 @@ >> perl.mak >> perl.mak.old >> +MYMETA.json >> MYMETA.yml >> blib >> blibdirs